Draft
Conversation
|
Output of |
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a local fixed-frame Trajectory abstraction for scene_synthesis, replacing direct usage of acoular.Trajectory and adding initial unit tests to validate core trajectory behaviors.
Changes:
- Added
scene_synthesis.trajectory.Trajectorybacked by a SciPy spline fit and exposed it fromscene_synthesis.__init__. - Switched
Source.trajectorytyping/imports to use the localTrajectory. - Updated trajectory test cases and added new unit tests for
interval,location(), andtraj().
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_trajectory.py | Adds direct unit tests for Trajectory.interval, Trajectory.location, and Trajectory.traj. |
| tests/cases_trajectory.py | Updates trajectory case fixtures to build scene_synthesis.Trajectory instances instead of acoular.Trajectory. |
| src/scene_synthesis/trajectory.py | Introduces the new fixed-frame Trajectory implementation using splprep/splev. |
| src/scene_synthesis/sources.py | Updates Source to depend on the local Trajectory type and refreshes docs/imports accordingly. |
| src/scene_synthesis/init.py | Re-exports Trajectory at the package top-level. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
tests/cases_trajectory.py:15
- The class docstring says these are cases for
FixedTrajectoryobjects, butcase_nonereturns[None]. Consider adjusting the docstring to reflect that cases may includeNone(or removecase_noneif only trajectories are intended), to keep the documentation consistent with the actual returned values.
class Trajectories:
"""Test cases for all :class:`scene_synthesis.trajectory.FixedTrajectory` objects.
New trajectories should be added here.
"""
def case_none(self):
"""No trajectory test case."""
return [None]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the fixed-frame trajectory starting point for scene synthesis.
Changes
scene_synthesis.trajectory.Trajectoryscene_synthesis.trajectory.SplineTrajectoryscene_synthesis.SplineTrajectoryIssue linkage
Trajectoryimplementation with fixed frame of reference #7Trajectorywith FOROT #5